15308555518/ MaxKB
1
0
Fork 0
mirror of https://github.com/1Panel-dev/MaxKB.git synced 2025-12-31 18:22:49 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

refactor: remove redundant validation logic from tool serializer 

--bug=1058282 --user=刘瑞斌 【工具】在工具模块，添加工具商店中的mysql查询工具，报错：Tool id does not exist https://www.tapd.cn/62980211/s/1725592
This commit is contained in:
CaptainB 2025-07-08 16:15:56 +08:00
parent b6cf80d6ef
commit 4be308078b
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apps/tools/serializers/tool.py
View File

@ -498,15 +498,6 @@ class ToolSerializer(serializers.Serializer):
workspace_id = serializers.CharField(required=True, label=_("workspace id"))
tool_id = serializers.UUIDField(required=True, label=_("tool id"))
def is_valid(self, *, raise_exception=False):
super().is_valid(raise_exception=True)
workspace_id = self.data.get('workspace_id')
query_set = QuerySet(Tool).filter(id=self.data.get('tool_id'))
if workspace_id:
query_set = query_set.filter(workspace_id=workspace_id)
if not query_set.exists():
raise AppApiException(500, _('Tool id does not exist'))
def add(self, instance, with_valid=True):
if with_valid:
self.is_valid(raise_exception=True)