From 4be308078b09c1cc02c63529c09938007ae9ed54 Mon Sep 17 00:00:00 2001 From: CaptainB Date: Tue, 8 Jul 2025 16:15:56 +0800 Subject: [PATCH] refactor: remove redundant validation logic from tool serializer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --bug=1058282 --user=刘瑞斌 【工具】在工具模块，添加工具商店中的mysql查询工具，报错：Tool id does not exist https://www.tapd.cn/62980211/s/1725592 --- apps/tools/serializers/tool.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/apps/tools/serializers/tool.py b/apps/tools/serializers/tool.py index 0acc42f2f..02d9aaf30 100644 --- a/apps/tools/serializers/tool.py +++ b/apps/tools/serializers/tool.py @@ -498,15 +498,6 @@ class ToolSerializer(serializers.Serializer): workspace_id = serializers.CharField(required=True, label=_("workspace id")) tool_id = serializers.UUIDField(required=True, label=_("tool id")) - def is_valid(self, *, raise_exception=False): - super().is_valid(raise_exception=True) - workspace_id = self.data.get('workspace_id') - query_set = QuerySet(Tool).filter(id=self.data.get('tool_id')) - if workspace_id: - query_set = query_set.filter(workspace_id=workspace_id) - if not query_set.exists(): - raise AppApiException(500, _('Tool id does not exist')) - def add(self, instance, with_valid=True): if with_valid: self.is_valid(raise_exception=True)