From 7a595d05b4389c0ad3af65a0a3b0d3c24b466f53 Mon Sep 17 00:00:00 2001
From: Junxiang Huang <wacmkxiaoyi@gmail.com>
Date: Fri, 4 Jul 2025 18:10:59 +0800
Subject: [PATCH] update notification server deployment & descriptions of
 relative variables

---
 manual/config/env.md                      | 6 ++----
 manual/extension/notification-server.md   | 1 -
 manual/repo/docker/ce/seafile-server.yml  | 2 +-
 manual/repo/docker/pro/seafile-server.yml | 2 +-
 manual/upgrade/upgrade_docker.md          | 1 -
 5 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/manual/config/env.md b/manual/config/env.md
index 1045c18a..8360c31d 100644
--- a/manual/config/env.md
+++ b/manual/config/env.md
@@ -113,10 +113,8 @@ For configurations about Metadata server in `.env`, please refer [here](../exten
 ## Notification server
 
 - `ENABLE_NOTIFICATION_SERVER`: Enable (`true`) or disable (`false`) notification feature for Seafile. Default is `false`.
-- `NOTIFICATION_SERVER_URL`: The [notification server](../extension/notification-server.md) url.
-
-!!! note "In Seafile cluster or standalone-deployment notification server"
-    In addition to `NOTIFICATION_SERVER_URL`, you also need to specify `INNER_NOTIFICATION_SERVER_URL=$NOTIFICATION_SERVER_URL`, which will be used for the connection between Seafile server and notification server.
+- `NOTIFICATION_SERVER_URL`: Used to do the connection between client (i.e., user's browser) and notification server. Default is `https://seafile.example.com/notification`. 
+- `INNER_NOTIFICATION_SERVER_URL`: Used to do the connection between Seafile server and notification server. Default is `http://notification-server:8083`.
 
 ## Cluster init configuration 
 
diff --git a/manual/extension/notification-server.md b/manual/extension/notification-server.md
index 21787b18..124ea396 100644
--- a/manual/extension/notification-server.md
+++ b/manual/extension/notification-server.md
@@ -30,7 +30,6 @@ then add or modify `ENABLE_NOTIFICATION_SERVER` and `NOTIFICATION_SERVER_URL`:
 
 ```sh
 ENABLE_NOTIFICATION_SERVER=true
-NOTIFICATION_SERVER_URL=$SEAFILE_SERVER_PROTOCOL://$SEAFILE_SERVER_HOSTNAME/notification
 ```
 
 Finally, You can run notification server with the following command:
diff --git a/manual/repo/docker/ce/seafile-server.yml b/manual/repo/docker/ce/seafile-server.yml
index 015de02a..1d0edd74 100644
--- a/manual/repo/docker/ce/seafile-server.yml
+++ b/manual/repo/docker/ce/seafile-server.yml
@@ -74,7 +74,7 @@ services:
       - MEMCACHED_PORT=${MEMCACHED_PORT:-11211}
       - ENABLE_NOTIFICATION_SERVER=${ENABLE_NOTIFICATION_SERVER:-false}
       - INNER_NOTIFICATION_SERVER_URL=${INNER_NOTIFICATION_SERVER_URL:-http://notification-server:8083}
-      - NOTIFICATION_SERVER_URL=${NOTIFICATION_SERVER_URL:-}
+      -  NOTIFICATION_SERVER_URL=${NOTIFICATION_SERVER_URL:-${SEAFILE_SERVER_PROTOCOL:-http}://${SEAFILE_SERVER_HOSTNAME:?Variable is not set or empty}/notification}
       - ENABLE_SEAFILE_AI=${ENABLE_SEAFILE_AI:-false}
       - SEAFILE_AI_SERVER_URL=${SEAFILE_AI_SERVER_URL:-http://seafile-ai:8888}
       - SEAFILE_AI_SECRET_KEY=${JWT_PRIVATE_KEY:?Variable is not set or empty}
diff --git a/manual/repo/docker/pro/seafile-server.yml b/manual/repo/docker/pro/seafile-server.yml
index 880c28a4..484f1093 100644
--- a/manual/repo/docker/pro/seafile-server.yml
+++ b/manual/repo/docker/pro/seafile-server.yml
@@ -86,7 +86,7 @@ services:
       - S3_SSE_C_KEY=${S3_SSE_C_KEY:-}
       - ENABLE_NOTIFICATION_SERVER=${ENABLE_NOTIFICATION_SERVER:-false}
       - INNER_NOTIFICATION_SERVER_URL=${INNER_NOTIFICATION_SERVER_URL:-http://notification-server:8083}
-      - NOTIFICATION_SERVER_URL=${NOTIFICATION_SERVER_URL:-}
+      - NOTIFICATION_SERVER_URL=${NOTIFICATION_SERVER_URL:-${SEAFILE_SERVER_PROTOCOL:-http}://${SEAFILE_SERVER_HOSTNAME:?Variable is not set or empty}/notification}
       - ENABLE_SEAFILE_AI=${ENABLE_SEAFILE_AI:-false}
       - SEAFILE_AI_SERVER_URL=${SEAFILE_AI_SERVER_URL:-http://seafile-ai:8888}
       - SEAFILE_AI_SECRET_KEY=${JWT_PRIVATE_KEY:?Variable is not set or empty}
diff --git a/manual/upgrade/upgrade_docker.md b/manual/upgrade/upgrade_docker.md
index 418aa0fa..caff3c9f 100644
--- a/manual/upgrade/upgrade_docker.md
+++ b/manual/upgrade/upgrade_docker.md
@@ -120,7 +120,6 @@ If you are using notification server in Seafile 12, please specify the notificat
 === "Deploy in the same host with Seafile"
     ```sh
     ENABLE_NOTIFICATION_SERVER=true
-    NOTIFICATION_SERVER_URL=$SEAFILE_SERVER_PROTOCOL://$SEAFILE_SERVER_HOSTNAME/notification
     ```
 === "Standalone deployment"
     ```sh