From 668ae5f0998b72e47e12e09110c856c37389650a Mon Sep 17 00:00:00 2001 From: samt42 Date: Fri, 3 Nov 2023 12:36:32 +0800 Subject: [PATCH] check file sha256sum by streaming to save memory usage. good for machine with limited memory size. --- cmd/kk/pkg/files/file.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/kk/pkg/files/file.go b/cmd/kk/pkg/files/file.go index 13746378..bba319b6 100644 --- a/cmd/kk/pkg/files/file.go +++ b/cmd/kk/pkg/files/file.go @@ -320,9 +320,9 @@ func sha256sum(path string) (string, error) { } defer file.Close() - data, err := io.ReadAll(file) - if err != nil { + hasher := sha256.New() + if _, err := io.Copy(hasher, file); err != nil { return "", err } - return fmt.Sprintf("%x", sha256.Sum256(data)), nil + return fmt.Sprintf("%x", hasher.Sum(nil)), nil }