From 590de952344dcdae28dcc1a2f908c33ac89d9b2d Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Wed, 26 Feb 2020 14:59:04 -0800 Subject: [PATCH] fix(v1): check repo url before using on Users page (#2331) * fix: check repoUrl before rendering edit link in users * refactor: prettier --- .../examples/basics/pages/en/users.js | 15 ++++++++++----- .../docusaurus-1.x/examples/basics/siteConfig.js | 2 +- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/docusaurus-1.x/examples/basics/pages/en/users.js b/packages/docusaurus-1.x/examples/basics/pages/en/users.js index 7eb0107316..97c9c57a56 100644 --- a/packages/docusaurus-1.x/examples/basics/pages/en/users.js +++ b/packages/docusaurus-1.x/examples/basics/pages/en/users.js @@ -18,7 +18,6 @@ class Users extends React.Component { return null; } - const editUrl = `${siteConfig.repoUrl}/edit/master/website/siteConfig.js`; const showcase = siteConfig.users.map(user => ( {user.caption} @@ -34,10 +33,16 @@ class Users extends React.Component {

This project is used by many folks

{showcase}
-

Are you using this project?

-
- Add your company - + {siteConfig.repoUrl && ( + <> +

Are you using this project?

+ + Add your company + + + )} diff --git a/packages/docusaurus-1.x/examples/basics/siteConfig.js b/packages/docusaurus-1.x/examples/basics/siteConfig.js index c8bb7bfe85..5b24b47398 100644 --- a/packages/docusaurus-1.x/examples/basics/siteConfig.js +++ b/packages/docusaurus-1.x/examples/basics/siteConfig.js @@ -104,7 +104,7 @@ const siteConfig = { // You may provide arbitrary config keys to be used as needed by your // template. For example, if you need your repo's URL... - // repoUrl: 'https://github.com/facebook/test-site', + // repoUrl: 'https://github.com/facebook/test-site', }; module.exports = siteConfig;