From 5444a230cf73cd4210ee57e03048d2d11c850212 Mon Sep 17 00:00:00 2001 From: Le Thi Van <48465000+vannyle@users.noreply.github.com> Date: Fri, 3 Jun 2022 17:28:27 +0200 Subject: [PATCH] feat: allow specifying custom target for FooterLogo (#7557) Co-authored-by: Joshua Chen --- .../src/__tests__/validateThemeConfig.test.ts | 1 + .../docusaurus-theme-classic/src/theme/Footer/Logo/index.tsx | 5 ++++- packages/docusaurus-theme-classic/src/validateThemeConfig.ts | 1 + packages/docusaurus-theme-common/src/utils/useThemeConfig.ts | 1 + 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/docusaurus-theme-classic/src/__tests__/validateThemeConfig.test.ts b/packages/docusaurus-theme-classic/src/__tests__/validateThemeConfig.test.ts index 850eeb0442..9c8bb7a79e 100644 --- a/packages/docusaurus-theme-classic/src/__tests__/validateThemeConfig.test.ts +++ b/packages/docusaurus-theme-classic/src/__tests__/validateThemeConfig.test.ts @@ -102,6 +102,7 @@ describe('themeConfig', () => { alt: 'Facebook Open Source Logo', src: 'img/oss_logo.png', href: 'https://opensource.facebook.com', + target: '_self', }, copyright: `Copyright © ${new Date().getFullYear()} Facebook, Inc. Built with Docusaurus.`, }, diff --git a/packages/docusaurus-theme-classic/src/theme/Footer/Logo/index.tsx b/packages/docusaurus-theme-classic/src/theme/Footer/Logo/index.tsx index 121e08f758..b2adfc1f00 100644 --- a/packages/docusaurus-theme-classic/src/theme/Footer/Logo/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/Footer/Logo/index.tsx @@ -32,7 +32,10 @@ function LogoImage({logo}: Props) { export default function FooterLogo({logo}: Props): JSX.Element { return logo.href ? ( - + ) : ( diff --git a/packages/docusaurus-theme-classic/src/validateThemeConfig.ts b/packages/docusaurus-theme-classic/src/validateThemeConfig.ts index d64b671f02..3ce3c618d7 100644 --- a/packages/docusaurus-theme-classic/src/validateThemeConfig.ts +++ b/packages/docusaurus-theme-classic/src/validateThemeConfig.ts @@ -364,6 +364,7 @@ export const ThemeConfigSchema = Joi.object({ width: Joi.alternatives().try(Joi.string(), Joi.number()), height: Joi.alternatives().try(Joi.string(), Joi.number()), href: Joi.string(), + target: Joi.string(), }), copyright: Joi.string(), links: Joi.alternatives( diff --git a/packages/docusaurus-theme-common/src/utils/useThemeConfig.ts b/packages/docusaurus-theme-common/src/utils/useThemeConfig.ts index b160bf307c..400b520bf5 100644 --- a/packages/docusaurus-theme-common/src/utils/useThemeConfig.ts +++ b/packages/docusaurus-theme-common/src/utils/useThemeConfig.ts @@ -75,6 +75,7 @@ export type FooterLogo = { srcDark?: string; width?: string | number; height?: string | number; + target?: string; href?: string; };