From 415a7973f1a9d2cbf3811ef2fc4e36e6d3df4dac Mon Sep 17 00:00:00 2001 From: hackerman <3372410+aeneasr@users.noreply.github.com> Date: Thu, 3 Dec 2020 18:23:26 +0100 Subject: [PATCH] fix(v2): load plugin commands async to fix broken plugin CLI commands `docs:version` (#3869) * fix(v2): load plugin commands asynchronously https://github.com/facebook/docusaurus/blame/master/packages/docusaurus/src/commands/external.ts#L12 changed the exported method to an async function, but the CLI loader was not updated to also run async, breaking things such as `npm run docusaurus docs:version `. * chore(v2): resolve lint issue --- packages/docusaurus/bin/docusaurus.js | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/packages/docusaurus/bin/docusaurus.js b/packages/docusaurus/bin/docusaurus.js index b69af5c3a9..7b8d6809e9 100755 --- a/packages/docusaurus/bin/docusaurus.js +++ b/packages/docusaurus/bin/docusaurus.js @@ -252,12 +252,16 @@ function isInternalCommand(command) { ].includes(command); } -if (!isInternalCommand(process.argv.slice(2)[0])) { - externalCommand(cli, path.resolve('.')); +async function run() { + if (!isInternalCommand(process.argv.slice(2)[0])) { + await externalCommand(cli, path.resolve('.')); + } + + cli.parse(process.argv); + + if (!process.argv.slice(2).length) { + cli.outputHelp(); + } } -cli.parse(process.argv); - -if (!process.argv.slice(2).length) { - cli.outputHelp(); -} +run();