From 16141fcd8040b22928217e0455c61158bb9ae7d3 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Mon, 17 Jan 2022 01:25:50 -0500 Subject: [PATCH] chore: enable a few fixable ESLint rules (#6380) * chore: enable react/jsx-one-expression-per-line * chore: enable import/first * chore: enable lines-between-class-members * revert class spacing Co-authored-by: Joshua Chen --- .eslintrc.js | 2 -- packages/docusaurus-utils/src/globUtils.ts | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 1041ce03d4..28a000035f 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -77,7 +77,6 @@ module.exports = { 'no-underscore-dangle': OFF, curly: [WARNING, 'all'], 'react/jsx-filename-extension': OFF, - 'react/jsx-one-expression-per-line': OFF, 'react/no-array-index-key': OFF, // Sometimes its ok, e.g. non-changing data. 'react/prop-types': OFF, 'react/destructuring-assignment': OFF, // Too many lines. @@ -97,7 +96,6 @@ module.exports = { WARNING, {disallowTypeAnnotations: false}, ], - 'import/first': OFF, 'import/order': OFF, 'import/prefer-default-export': OFF, 'lines-between-class-members': OFF, diff --git a/packages/docusaurus-utils/src/globUtils.ts b/packages/docusaurus-utils/src/globUtils.ts index 196997caa5..fbbf8aa51b 100644 --- a/packages/docusaurus-utils/src/globUtils.ts +++ b/packages/docusaurus-utils/src/globUtils.ts @@ -7,10 +7,11 @@ // Globby/Micromatch are the 2 libs we use in Docusaurus consistently -export {default as Globby} from 'globby'; import Micromatch from 'micromatch'; // Note: Micromatch is used by Globby import path from 'path'; +export {default as Globby} from 'globby'; + // The default patterns we ignore when globbing // using _ prefix for exclusion by convention export const GlobExcludeDefault = [