From 5ceb8a7ff907746166cfe0c667a6c0edb94c680d Mon Sep 17 00:00:00 2001
From: wangdan-fit2cloud <79562285+wangdan-fit2cloud@users.noreply.github.com>
Date: Fri, 28 Mar 2025 15:33:44 +0800
Subject: [PATCH] feat: Internal function can modify names

---
 .../locales/lang/en-US/views/function-lib.ts  |  1 +
 .../locales/lang/zh-CN/views/function-lib.ts  |  3 +-
 .../lang/zh-Hant/views/function-lib.ts        |  3 +-
 .../component/AddInternalFunctionDialog.vue   | 11 +++---
 ui/src/views/function-lib/index.vue           | 37 ++++++++++++-------
 5 files changed, 34 insertions(+), 21 deletions(-)

diff --git a/ui/src/locales/lang/en-US/views/function-lib.ts b/ui/src/locales/lang/en-US/views/function-lib.ts
index 1ca7103b3..05f5f60a8 100644
--- a/ui/src/locales/lang/en-US/views/function-lib.ts
+++ b/ui/src/locales/lang/en-US/views/function-lib.ts
@@ -33,6 +33,7 @@ export default {
     form: {
       functionName: {
         label: 'Name',
+        name: 'Function Name',
         placeholder: 'Please enter the function name',
         requiredMessage: 'Please enter the function name'
       },
diff --git a/ui/src/locales/lang/zh-CN/views/function-lib.ts b/ui/src/locales/lang/zh-CN/views/function-lib.ts
index b0767b644..573d7b57e 100644
--- a/ui/src/locales/lang/zh-CN/views/function-lib.ts
+++ b/ui/src/locales/lang/zh-CN/views/function-lib.ts
@@ -31,6 +31,7 @@ export default {
     form: {
       functionName: {
         label: '名称',
+        name: '函数名称',
         placeholder: '请输入函数名称',
         requiredMessage: '请输入函数名称'
       },
@@ -63,7 +64,7 @@ export default {
         paramInfo2: '使用函数时不显示',
         code: '函数内容（Python）',
         selectPlaceholder: '请选择参数',
-        inputPlaceholder: '请输入参数值',
+        inputPlaceholder: '请输入参数值'
       },
       debug: {
         run: '运行',
diff --git a/ui/src/locales/lang/zh-Hant/views/function-lib.ts b/ui/src/locales/lang/zh-Hant/views/function-lib.ts
index 789cbf0ec..f39fea51a 100644
--- a/ui/src/locales/lang/zh-Hant/views/function-lib.ts
+++ b/ui/src/locales/lang/zh-Hant/views/function-lib.ts
@@ -31,6 +31,7 @@ export default {
     form: {
       functionName: {
         label: '名稱',
+        name: '函數名稱',
         placeholder: '請輸入函數名稱',
         requiredMessage: '請輸入函數名稱'
       },
@@ -63,7 +64,7 @@ export default {
         paramInfo2: '使用函數時不顯示',
         code: '函数内容（Python）',
         selectPlaceholder: '請选择參數',
-        inputPlaceholder: '請輸入參數值',
+        inputPlaceholder: '請輸入參數值'
       },
       debug: {
         run: '運行',
diff --git a/ui/src/views/function-lib/component/AddInternalFunctionDialog.vue b/ui/src/views/function-lib/component/AddInternalFunctionDialog.vue
index 5f604404c..2f6514bc4 100644
--- a/ui/src/views/function-lib/component/AddInternalFunctionDialog.vue
+++ b/ui/src/views/function-lib/component/AddInternalFunctionDialog.vue
@@ -1,6 +1,6 @@
 <template>
   <el-dialog
-    :title="$t('views.functionLib.functionForm.form.functionName.placeholder')"
+    :title="$t('views.functionLib.functionForm.form.functionName.name')"
     v-model="dialogVisible"
     :close-on-click-modal="false"
     :close-on-press-escape="false"
@@ -23,7 +23,7 @@
       <span class="dialog-footer">
         <el-button @click.prevent="dialogVisible = false"> {{ $t('common.cancel') }} </el-button>
         <el-button type="primary" @click="submit(fieldFormRef)" :loading="loading">
-          {{ $t('common.add') }}
+          {{ isEdit ? $t('common.save') : $t('common.add') }}
         </el-button>
       </span>
     </template>
@@ -39,6 +39,7 @@ const emit = defineEmits(['refresh'])
 
 const fieldFormRef = ref()
 const loading = ref<boolean>(false)
+const isEdit = ref<boolean>(false)
 
 const form = ref<any>({
   name: ''
@@ -64,11 +65,11 @@ watch(dialogVisible, (bool) => {
   }
 })
 
-const open = (row: any) => {
+const open = (row: any, edit: boolean) => {
   if (row) {
     form.value = cloneDeep(row)
   }
-
+  isEdit.value = edit || false
   dialogVisible.value = true
 }
 
@@ -76,7 +77,7 @@ const submit = async (formEl: FormInstance | undefined) => {
   if (!formEl) return
   await formEl.validate((valid) => {
     if (valid) {
-      emit('refresh', form.value)
+      emit('refresh', form.value, isEdit.value)
       dialogVisible.value = false
     }
   })
diff --git a/ui/src/views/function-lib/index.vue b/ui/src/views/function-lib/index.vue
index 6969d18c1..eb41c2c64 100644
--- a/ui/src/views/function-lib/index.vue
+++ b/ui/src/views/function-lib/index.vue
@@ -1,12 +1,6 @@
 <template>
   <div class="function-lib-list-container p-24" style="padding-top: 16px">
-    <el-tabs
-      v-model="functionType"
-      @tab-change="
-      tabChangeHandle
-    
-      "
-    >
+    <el-tabs v-model="functionType" @tab-change="tabChangeHandle">
       <el-tab-pane :label="$t('views.functionLib.title')" name="PUBLIC"></el-tab-pane>
       <el-tab-pane :label="$t('views.functionLib.internalTitle')" name="INTERNAL"></el-tab-pane>
     </el-tabs>
@@ -165,6 +159,14 @@
                       </el-button>
                       <template #dropdown>
                         <el-dropdown-menu>
+                          <el-dropdown-item
+                            v-if="item.template_id"
+                            :disabled="item.permission_type === 'PUBLIC' && !canEdit(item)"
+                            @click.stop="addInternalFunction(item, true)"
+                          >
+                            <el-icon><EditPen /></el-icon>
+                            {{ $t('common.edit') }}
+                          </el-dropdown-item>
                           <el-dropdown-item
                             v-if="!item.template_id"
                             :disabled="item.permission_type === 'PUBLIC' && !canEdit(item)"
@@ -366,17 +368,24 @@ async function openDescDrawer(row: any) {
   InternalDescDrawerRef.value.open(content, row)
 }
 
-function addInternalFunction(data?: any) {
-  AddInternalFunctionDialogRef.value.open(data)
+function addInternalFunction(data?: any, isEdit?: boolean) {
+  AddInternalFunctionDialogRef.value.open(data, isEdit)
 }
 
-function confirmAddInternalFunction(data?: any) {
-  functionLibApi
-    .addInternalFunction(data.id, { name: data.name }, changeStateloading)
-    .then((res) => {
-      MsgSuccess(t('common.submitSuccess'))
+function confirmAddInternalFunction(data?: any, isEdit?: boolean) {
+  if (isEdit) {
+    functionLibApi.putFunctionLib(data?.id as string, data, loading).then((res) => {
+      MsgSuccess(t('common.saveSuccess'))
       searchHandle()
     })
+  } else {
+    functionLibApi
+      .addInternalFunction(data.id, { name: data.name }, changeStateloading)
+      .then((res) => {
+        MsgSuccess(t('common.addSuccess'))
+        searchHandle()
+      })
+  }
 }
 
 function searchHandle() {